-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(mysql): improve random(with LCG) password for mysql user #517
Conversation
Use Linear Congruential Generator to generate a random number between 0 and 1, in stead of Math.random(). |
extensions/mysql/index.js
Outdated
const generateRandomPassword = () => { | ||
/** | ||
* LCG Random | ||
* @example cosnt random = (lcgRandom()) |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
fixed a spelling error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@imzhengfei sorry for the delay on this! would it be possible to move the generateRandomPassword function to a method on the nginx extension class? keeps things a bit cleaner :)
@acburdine I am not sure, do you mean MySQLExtension class ? |
@imzhengfei my apologies, yes that's what I meant. However, as I commented here, there's another issue in that the initial |
fix: #511