Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(update): add pre-stable warning message with docs link #372

Merged
merged 1 commit into from
Jul 21, 2017

Conversation

acburdine
Copy link
Member

closes #364

  • if an instance was installed with a pre-stable version of Ghost-CLI, this message is output so that people know they need to do things to update their instance to work with the newest CLI version

@acburdine acburdine requested a review from ErisDS July 21, 2017 03:26
@acburdine
Copy link
Member Author

cc @ErisDS for a wording check. I went ahead and added a docs section at the link outlined in the PR - but in the case that the link changes I wanted to hold off on merging this.

Feel free to merge though if the link looks good / the docs are correct 👍

@coveralls
Copy link

Coverage Status

Coverage remained the same at 57.848% when pulling d9541f9 on acburdine:warn-pre-1.0 into bc845de on TryGhost:master.

@ErisDS
Copy link
Member

ErisDS commented Jul 21, 2017

@acburdine Link is now https://docs.ghost.org/docs/how-to-upgrade-ghost#section-upgrading-ghost-cli

Slightly different wording:

Ghost was installed with Ghost-CLI v${instance.cliConfig.get('cli-version')}, which is a pre-release version. Your Ghost install is using out-of-date configuration & requires manual changes. \n

closes TryGhost#364
- if an instance was installed with a pre-stable version of Ghost-CLI, this message is output so that people know they need to do things to update their instance to work with the newest CLI version
@acburdine
Copy link
Member Author

@ErisDS done - good to review again

@coveralls
Copy link

Coverage Status

Coverage remained the same at 57.848% when pulling 4225a55 on acburdine:warn-pre-1.0 into bc845de on TryGhost:master.

@ErisDS ErisDS merged commit 72b461f into TryGhost:master Jul 21, 2017
@acburdine acburdine deleted the warn-pre-1.0 branch July 21, 2017 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output notice when a non-stable version of ghost-cli was used to install
3 participants