Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mail config message after installation #278

Merged
merged 1 commit into from
Jul 5, 2017
Merged

Add mail config message after installation #278

merged 1 commit into from
Jul 5, 2017

Conversation

cobbspur
Copy link
Member

@cobbspur cobbspur commented Jul 5, 2017

refs #216

  • adds a little ui message to guide people towards docs for mail config

@cobbspur cobbspur requested a review from kirrg001 July 5, 2017 16:25
@coveralls
Copy link

Coverage Status

Coverage remained the same at 56.714% when pulling 96ebece on cobbspur:mail into 2d2c979 on TryGhost:master.

@acburdine
Copy link
Member

So one of the side effects of this change is it will be output every time Ghost start is run, regardless of whether or not the user is using direct mail.

IMO this message should be moved into the config command, after this line: https://github.com/TryGhost/Ghost-CLI/blob/master/lib/commands/config/index.js#L64 . There should also probably be a check to see if the user actually has defined any mail, and if so, skip outputting the UI message.

acburdine
acburdine reviewed Jul 5, 2017
View reviewed changes
lib/commands/start.js Outdated
@@ -61,6 +61,8 @@ class StartCommand extends Command {
return this.ui.run(processInstance.enable(), 'Enabling instance startup on server boot');
}).then(() => {
this.ui.log(`You can access your blog at ${instance.config.get('url')}`, 'cyan');
this.ui.log(`\nGhost uses direct mail by default`, `green`);

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

@coveralls
Copy link

Coverage Status

Coverage remained the same at 56.714% when pulling 88553cf on cobbspur:mail into 2d2c979 on TryGhost:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 56.714% when pulling 1875708 on cobbspur:mail into 2d2c979 on TryGhost:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 56.714% when pulling 0d01b5c on cobbspur:mail into 2d2c979 on TryGhost:master.

@cobbspur
Add mail config message after installation
b0c3156 
refs TryGhost#216
- adds a little ui message to guide people towards docs for mail config
@coveralls
Copy link

Coverage Status

Coverage remained the same at 56.714% when pulling b0c3156 on cobbspur:mail into 2d2c979 on TryGhost:master.

acburdine
acburdine approved these changes Jul 5, 2017
View reviewed changes
Copy link
Member

@acburdine acburdine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@acburdine acburdine merged commit 8aac988 into TryGhost:master Jul 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acburdine acburdine acburdine approved these changes

@kirrg001 kirrg001 Awaiting requested review from kirrg001

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cobbspur @coveralls @acburdine