✨ feat(setup): enable systemd service during setup #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs TryGhost#216, TryGhost#248 - add an extra step to enable systemd on setup - this is what tells systemd to start the service on server restart - Update the template to contain docs link
|
@ErisDS could I get you to rebase this against master? I won't be able to do it myself 😛 |
|
sooo...kind of stole the thunder on this as I wanted to get the full feature of enable/disable in. Would it be possible to update this PR/message just to update the docs link in the template? |
|
Doesn't really matter how it gets in :) You are definitely more well-placed to do a rebase on this than I - I just tried and I don't know where any files are anymore and there are no instructions or explanations that I can find, so I'm going to have to relearn the codebase: It's totally possible for you to rebase as PRs can be pushed to. If the only thing left to do is a text change then might as well just commit that directly? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick version for now, to ensure that enable is called and Ghost doesn't fail to start on reboot of servers.
I will try to revisit the better plan in #248 next week,
refs #216, #248