Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I am become uninstall, destroyer of ghost instances #200

Merged
merged 2 commits into from
May 6, 2017
Merged

I am become uninstall, destroyer of ghost instances #200

merged 2 commits into from
May 6, 2017

Conversation

acburdine
Copy link
Member

@acburdine acburdine commented May 6, 2017 •
edited
Loading

Almost done - just need to test on Linux and also add a check for the nginx service so that it doesn't try to delete files that aren't there. done!

closes #187

@acburdine
feat(ui): support an error of "false" that exits without logging
e863aea 
- this can simplify some of the weird promise chaining in that if a
command needs to exit without doing anything else it can just reject
with false as the rejection
@acburdine acburdine changed the title I am become uninstall destroyer of ghost instances [WIP] I am become uninstall destroyer of ghost instances May 6, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.9%) to 54.75% when pulling 9e4bf81 on acburdine:i-am-become-uninstall-destroyer-of-ghost-instances into f0af011 on TryGhost:master.

@acburdine
Copy link
Member Author

NOTE: there is currently a bug with this command because the "root" directory in the ghost install directory has a root ownership (if you create an SSL certificate). While it could be fixed as part of this issue, I will solve it instead as a part of the larger changes in #189 and #190

@acburdine acburdine force-pushed the i-am-become-uninstall-destroyer-of-ghost-instances branch from 9e4bf81 to dbd1d2a Compare May 6, 2017 12:47
@acburdine acburdine changed the title [WIP] I am become uninstall destroyer of ghost instances I am become uninstall, destroyer of ghost instances May 6, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.05%) to 54.561% when pulling dbd1d2a on acburdine:i-am-become-uninstall-destroyer-of-ghost-instances into f0af011 on TryGhost:master.

@acburdine
feat(uninstall): add ghost uninstall command
b2f279c 
closes TryGhost#187
- adds `ghost uninstall` command that will delete the ghost instance and
any related configuration files
@acburdine acburdine force-pushed the i-am-become-uninstall-destroyer-of-ghost-instances branch from dbd1d2a to b2f279c Compare May 6, 2017 12:50
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.05%) to 54.561% when pulling b2f279c on acburdine:i-am-become-uninstall-destroyer-of-ghost-instances into f0af011 on TryGhost:master.

@acburdine acburdine merged commit f15a6a6 into TryGhost:master May 6, 2017
@acburdine acburdine deleted the i-am-become-uninstall-destroyer-of-ghost-instances branch May 6, 2017 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ghost uninstall command
2 participants
@acburdine @coveralls