Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(stack): refactor stack check & allow ubuntu 20 #1313

Merged
merged 1 commit into from
Oct 9, 2020
Merged

feat(stack): refactor stack check & allow ubuntu 20 #1313

merged 1 commit into from
Oct 9, 2020

Conversation

acburdine
Copy link
Member

refs #853,#1265

  • refactor system stack check to use systeminformation to check support
  • update ubuntu allowed versions to support Ubuntu 20

@acburdine
feat(stack): refactor stack check & allow ubuntu 20
e4b4c6d 
refs TryGhost#853,TryGhost#1265
- refactor system stack check to use systeminformation to check support
- update ubuntu allowed versions to support Ubuntu 20
@acburdine acburdine mentioned this pull request Oct 9, 2020
Closed
vikaspotluri123
vikaspotluri123 approved these changes Oct 9, 2020
View reviewed changes
Copy link
Member

@vikaspotluri123 vikaspotluri123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏾

We'll probably want to add an extension hook for other process managers (thinking about supervisor) to run checks here

@acburdine acburdine merged commit 9ad75e0 into TryGhost:master Oct 9, 2020
@acburdine acburdine deleted the feat/ubuntu-20-support branch October 9, 2020 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikaspotluri123 vikaspotluri123 vikaspotluri123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acburdine @vikaspotluri123