Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install a non released Ghost #59

Closed
kirrg001 opened this issue Oct 17, 2016 · 7 comments · Fixed by #444
Closed

Install a non released Ghost #59

kirrg001 opened this issue Oct 17, 2016 · 7 comments · Fixed by #444

Comments

@kirrg001
Copy link
Contributor

kirrg001 commented Oct 17, 2016

I've added a tarball link instead of the Ghost version, that worked pretty good.
So instead of version, i have added my Ghost tarball link.
https://github.com/TryGhost/Ghost-CLI/blob/master/lib/tasks/npm-download.js#L27

How about adding an option for it?
Background: i don't want to wait until a new release zip is available. I would like to have an easy way to test my Ghost branch with Ghost-CLI.

If there is already an easy way, we close this issue 🌮 !

@kirrg001
Copy link
Contributor Author

we need to ensure submodules get installed correctly

@ErisDS
Copy link
Member

ErisDS commented Oct 18, 2016

I think this steps outside the realms of what the ghost-cli is intended to do.

In order to install from a tarball, Ghost-cli would need to know about and be able to handle all of the build steps for Ghost, including handling the submodules, npm & bower install for ghost-admin, ember build, etc etc.

I agree that it would be useful to have a way to test ghost-cli, however I don't think that installing direct from a github tarball is the right solution. Instead, it would be better (I think) to perhaps be able to link a local pre-built zip or similar.

@kirrg001
Copy link
Contributor Author

kirrg001 commented Oct 18, 2016

Instead, it would be better (I think) to perhaps be able to link a local pre-built zip or similar.

Agree. Will rename the issue to something general. At the end: i am fine with any solution as long as it's official and easy to use :)

@kirrg001 kirrg001 changed the title Install Ghost via tarball Install a non released Ghost Oct 18, 2016
@acburdine
Copy link
Member

Personally I'm in favor of a ghost link command - you could pass it the path to your local ghost install and it would symlink it into the ghost-cli setup.

@kirrg001
Copy link
Contributor Author

Personally I'm in favor of a ghost link command - you could pass it the path to your local ghost install and it would symlink it into the ghost-cli setup.

👍

@cbanowsky
Copy link

Just as nvm has the nvm ls-remote' Ghost should have a lsansls-remote` so specific releases can be installed and then choose an unstable version if they want to run bleeding edge.

@acburdine
Copy link
Member

@cbanowsky If you're talking about installing the master branch of Ghost, then I'd say no, as doing so requires several other commands needed to set up development dependencies and build the ember admin application, all of which is outside of Ghost-CLI's scope IMO.

If you're talking about future (post-1.0) builds (such as nightly builds, and iirc they are an idea that's still on the table), then I'd say its not a bad idea to consider once those actually become a thing.

acburdine added a commit to acburdine/Ghost-CLI that referenced this issue Aug 13, 2017
closes TryGhost#59 [ci skip]
- add a --zip option to both `ghost install` and `ghost update` so that unreleased new Ghost versions can be tested using install and update
- deps: [email protected]
acburdine added a commit to acburdine/Ghost-CLI that referenced this issue Aug 14, 2017
closes TryGhost#59
- add a --zip option to both `ghost install` and `ghost update` so that unreleased new Ghost versions can be tested using install and update
- deps: [email protected]
- update tests
acburdine added a commit to acburdine/Ghost-CLI that referenced this issue Aug 14, 2017
closes TryGhost#59
- add a --zip option to both `ghost install` and `ghost update` so that unreleased new Ghost versions can be tested using install and update
- deps: [email protected]
- update tests
acburdine added a commit that referenced this issue Aug 14, 2017
closes #59
- add a --zip option to both `ghost install` and `ghost update` so that unreleased new Ghost versions can be tested using install and update
- deps: [email protected]
- update tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants