Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Running ghost install with --no-prompt option fails if mysql is not installed #410

Closed
acburdine opened this issue Jul 31, 2017 · 2 comments · Fixed by #411
Closed

Running ghost install with --no-prompt option fails if mysql is not installed #410

acburdine opened this issue Jul 31, 2017 · 2 comments · Fixed by #411
Assignees
@acburdine
Labels
bug

Comments

@acburdine
Copy link
Member

See #318 (comment)

We should throw an error and exit rather than prompt if --no-prompt is passed as an option.
@acburdine acburdine added the bug label Jul 31, 2017
@acburdine acburdine self-assigned this Jul 31, 2017
@mathiasjakobsen
Copy link

mathiasjakobsen commented Jul 31, 2017 •
edited
Loading

@acburdine, throwing an error is not corresponding with the UI message?

Local MySQL install not found. You can ignore this if you are using a remote MySQL host.

In my case I'm actually running a remote database, which shouldn't cause the setup too fail.

@acburdine
Copy link
Member Author

oooh ok, yeah that's a good point - will add that check in.

acburdine added a commit to acburdine/Ghost-CLI that referenced this issue Jul 31, 2017
@acburdine
fix(doctor): fix prompting and error handling with --no-prompt
2b46281 
closes TryGhost#410
- throw errors instead if prompts are disabled
- fix error if remote mysql host is used
@acburdine acburdine mentioned this issue Jul 31, 2017
Merged
acburdine added a commit that referenced this issue Jul 31, 2017
@acburdine
fix(doctor): fix prompting and error handling with --no-prompt
1641676 
closes #410
- throw errors instead if prompts are disabled
- fix error if remote mysql host is used
@devster31 devster31 mentioned this issue Apr 16, 2019
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acburdine acburdine

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(doctor): fix prompting and error handling with --no-prompt acburdine/Ghost-CLI
2 participants
@mathiasjakobsen @acburdine