Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--quiet results in enable/disable being skipped #335

Closed
ErisDS opened this issue Jul 10, 2017 · 4 comments · Fixed by #337
Closed

--quiet results in enable/disable being skipped #335

ErisDS opened this issue Jul 10, 2017 · 4 comments · Fixed by #337
Labels

Comments

@ErisDS
Copy link
Member

ErisDS commented Jul 10, 2017

The start and stop commands both have a --quiet flag.

This flag prevents the UI from outputting anything on start/stop, but also prevents the enable/disable step from happening.

I am not sure what the intention of the --quiet flag is. It only appears in a handful of places, was it a precursor to --no-prompt?

@acburdine if you can clarify the intention here, I think I can fix/remove this. It's totally non-urgent except in that I am going to be removing the quiet flag when passed to stop from uninstall so that the systemd disable command is run on uninstall.

@acburdine
Copy link
Member

so it's not an official flag actually, I added it in there so that the start/stop commands, when called programmatically from something like ghost update/ghost uninstall, wouldn't log anything out as it would mess up the listr flow.

Not as consequential now that ghost restart doesn't actually use start & stop, so am 👍 for any changes that you want to make, just need to double check that whatever solution still works correctly with ghost update as well as ghost uninstall, as those are the two places where stop is called programmatically.

@ErisDS
Copy link
Member Author

ErisDS commented Jul 10, 2017

Yeah, now that I've removed it, I see I get "Stopping Ghost" output twice, so can see what it was meant to do...

@acburdine
Copy link
Member

there should be a better way to go about this - maybe adding a second property to the run method in the stop command?

ErisDS added a commit to ErisDS/Ghost-CLI that referenced this issue Jul 10, 2017
closes TryGhost#335

- implement --quiet inside of ui.run
ErisDS added a commit to ErisDS/Ghost-CLI that referenced this issue Jul 10, 2017
closes TryGhost#335

- implement --quiet inside of ui.run
@ErisDS
Copy link
Member Author

ErisDS commented Jul 10, 2017

I've had a go 😁

ErisDS added a commit to ErisDS/Ghost-CLI that referenced this issue Jul 10, 2017
closes TryGhost#335

- implement --quiet inside of ui.run
ErisDS added a commit that referenced this issue Jul 10, 2017
closes #335

- implement --quiet inside of ui.run
ErisDS added a commit to ErisDS/Ghost-CLI that referenced this issue Jul 10, 2017
closes TryGhost#335

- implement --quiet inside of ui.run
acburdine pushed a commit that referenced this issue Jul 10, 2017
closes #335

- implement --quiet inside of ui.run
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants