Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default log file #219

Closed
PaszaVonPomiot opened this issue Jun 21, 2017 · 2 comments · Fixed by #237
Closed

Default log file #219

PaszaVonPomiot opened this issue Jun 21, 2017 · 2 comments · Fixed by #237
Assignees
Milestone

Comments

@PaszaVonPomiot
Copy link

There seems to be incorrect time in filename of ghost-cli log. From my point of view it would be much better to have single log file by default without time and date in filename. You may also consider moving log files by default to standard log path eg.: /var/log/ghost/<pname>.log.

[ghost@strefadyskomfortu strefadysk_prd]$ date
Wed Jun 21 16:52:29 CEST 2017
[ghost@strefadyskomfortu strefadysk_prd]$ ls ghost*
ls: cannot access ghost*: No such file or directory
[ghost@strefadyskomfortu strefadysk_prd]$ ghost start
 ✔ Validating config
An error occurred.
Message: 'Ghost is already running.'


Debug Information:
    Node Version: v6.11.0
    Ghost-CLI Version: 1.0.0-alpha.18
    Environment: production
    Command: 'ghost start'
[ghost@strefadyskomfortu strefadysk_prd]$ ls ghost*
**ghost-cli-debug-2017-06-21T14:52:44.524Z.log**
[ghost@strefadyskomfortu strefadysk_prd]$ date
Wed Jun 21 16:53:11 CEST 2017

Ghost Version: beta.1
OS: Centos 7.3
Database: MariaDB

@ghost
Copy link

ghost commented Jun 21, 2017

@PaszaVonPomiot Not sure why the date is off - it might be because the date ghost-cli uses is in UTC?

As far as logging goes, I definitely think the date/time should be kept in if only for ordering, especially if the logs are moved to a central place (which is being considered). I would say, though, that the log location should be user-specific and not in /var/log, mainly because ghost-cli only outputs logs if something goes wrong.

@PaszaVonPomiot
Copy link
Author

PaszaVonPomiot commented Jun 21, 2017

I use UTC+1 timezone and the hour in filename is shifted by 2h. But that's low priority issue.

Edit: It's GMT+1 so 2h difference is correct

@acburdine acburdine self-assigned this Jun 26, 2017
@acburdine acburdine added this to the 1.0.0-rc.1 milestone Jun 26, 2017
acburdine added a commit to acburdine/Ghost-CLI that referenced this issue Jun 27, 2017
closes TryGhost#219, TryGhost#203, TryGhost#170
- addition of System and Interface classes to manage configuration/environment
- fix update command weirdness
- cleanup & fix process name handling
acburdine added a commit to acburdine/Ghost-CLI that referenced this issue Jun 27, 2017
closes TryGhost#219, TryGhost#203, TryGhost#170
- addition of System and Interface classes to manage configuration/environment
- fix update command weirdness
- cleanup & fix process name handling
- move error logging to user home directory
acburdine added a commit that referenced this issue Jun 27, 2017
closes #219, #203, #170
- addition of System and Interface classes to manage configuration/environment
- fix update command weirdness
- cleanup & fix process name handling
- move error logging to user home directory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants