Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we are in npm/webpack world we don't need these to give us scope
Proposed Changes
I wanted to get rid of the all the angular-era IIFE's (you know,
(function(){ /* code goes here */ })()
that wraps everything) as they are no longer needed we are in webpack (each file is it's own scope).I wrote a jscodeshift script to do it (see https://gist.github.com/nicksellen/cbe11ad0ca9073ce762c02c897e67d1c), I was thinking we can just keep it as a standalone script (not in repo), make one BIG change PR to change everything, but then people can run the script in their branches to minimise big change.
Whaddya think?
Testing Instructions
To run the script:
Fixes #