Eslint: add comma-dangle always multi-line rule #1163
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
comma-dangle
Eslint rule fromnever
toalways multi-line
eslint --fix
to all files(I separated these steps into two commits)
This is kinda paving the way to eventually start using Prettier in the codebase (#932), although it's possible to turn off
trailingComma
option in Prettier so this isn't strickly necessary.That said, it's a good convention to have since it's a bit more convenient to re-arrange different lists (variables, imports, etc) alphabetically without comma-hassle. 😁
This will also cause one less line-change in diffs when modifying the end of multi-line lists.
Testing Instructions
npm run lint
passing?