Fix eslint no-prototype-builtins issues
#1127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simison
commented
Nov 15, 2019
| @@ -41,14 +41,14 @@ function validateCreate(req) { | |||
|
|
|||
| // Values of interactions must be boolean | |||
| ['met', 'hostedMe', 'hostedThem'].forEach(function (interaction) { | |||
| if (req.body.interactions && req.body.interactions.hasOwnProperty(interaction) && typeof req.body.interactions[interaction] !== 'boolean') { | |||
| if (_.has(req, ['body', 'interactions', interaction]) && typeof req.body.interactions[interaction] !== 'boolean') { | |||
There was a problem hiding this comment.
Good win especially here since we're checking for a path two levels deep.
mrkvon
approved these changes
Nov 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a smaller iteration step from #1126 where I'm converting eslint config to extend
eslint:recommended.That ruleset includes
no-prototype-builtinsrule and there were a few warnings so I set to fix those. Instead of using elaborateObject.prototype.hasOwnProperty.call(foo, "bar")I'm just using Lodash'shashere instead.I generally like using vanilla JS over Lodash especially in frontend code but this is all server-side and just feels more readable in these cases. We're also already using Lodash in all these files.
Proposed Changes
_.has()overhasOwnPropertychecksTesting Instructions