-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to tsup for building the dist #241
Conversation
karlobencic
commented
Feb 14, 2025
- Added tsup as the build tool to replace raw tsc
- Configured tsup to output ES modules with proper directory structure
- Simpler and faster builds
- Better tree-shaking through ES modules
- Cleaner output structure without src directory nesting
🦋 Changeset detectedLatest commit: 2882fe4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A couple of questions:
|
No, prebuild/postbuild are called by npm, not tsup. This means postbuild won't run if the build fails, I've now made a better approach by removing those scripts and using compile-time variables. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The missing prop should go into a separate PR or at least have its own entry in the changeset. The tsup change itself seems fine.