Move scrape.pid to temp dir #3785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation for this change was running scraper inside Docker, but I think it improves chifra runnig outside Docker, too.
Very, very rarely (after Ctrl-C fix) the
.pidfile was left after scraper had been killed. Moving the file to/tmpfixes the problem for Docker (because any directory not mounted to the host filesystem is ephemeral), but there's no guarantee that if running directly the OS will empty/tmp.The code I added tries to use so called "variable directory" which is guaranteed to be emptied by the OS: https://refspecs.linuxfoundation.org/FHS_3.0/fhs/ch03s15.html
For Linux, it's
/run/$UID, for Mac/usr/local/var/run. If the directory doesn't exist, we fall back to/tmp.