Trying to clean up initialization

src/apps/chifra/cmd/root_initialize.go

@@ -14,6 +14,7 @@ import (
 	"github.com/TrueBlocks/trueblocks-core/src/apps/chifra/pkg/colors"
 	"github.com/TrueBlocks/trueblocks-core/src/apps/chifra/pkg/config"
 	"github.com/TrueBlocks/trueblocks-core/src/apps/chifra/pkg/logger"
+	"github.com/TrueBlocks/trueblocks-core/src/apps/chifra/pkg/utils"
 )
 
 // Initialize makes sure everything is ready to run. These routines don't return if they aren't
@@ -43,7 +44,7 @@ func VerifyOs() {
 
 // VerifyMigrations will panic if the installation is not properly migrated
 func VerifyMigrations() {
-	if isPermitted() {
+	if utils.IsPermitted() {
 		// Allow certain status and config routes to pass so as to aide user in migrating...
 		return
 	}
@@ -111,35 +112,3 @@ func VerifyMigrations() {
 		}
 	}
 }
-
-func isPermitted() bool {
-	isStatus := false
-	isConfig := false
-	hasPaths := false
-	hasEdit := false
-	cnt := len(os.Args)
-	for _, arg := range os.Args {
-		if arg == "help" {
-			return false
-		} else if arg == "status" {
-			isStatus = true
-		} else if arg == "config" {
-			isConfig = true
-		} else if arg == "--paths" {
-			hasPaths = true
-		} else if arg == "edit" {
-			hasEdit = true
-		} else if arg != "--verbose" {
-			isStatus = false
-			isConfig = false
-		} else {
-			cnt-- // allow --verbose
-		}
-	}
-
-	if isStatus && cnt == 2 {
-		return true
-	}
-
-	return isConfig && (hasPaths || hasEdit) && cnt < 4
-}

src/apps/chifra/internal/abis/handle_find.go

@@ -50,7 +50,10 @@ func (opts *AbisOptions) HandleAbiFind() error {
 				if bytes.Equal(sigBytes[:len(str)], str) {
 					scanBar.Found++
 					logger.Progress(len(opts.Find) < 2, "Found", scanBar.Found, "of", scanBar.Wanted, arg, testSig)
-					found := types.Function{Encoding: arg, Signature: testSig.(string)}
+					found := types.Function{
+						Encoding:  arg,
+						Signature: testSig.(string),
+					}
 					if testMode {
 						mutex.Lock()
 						results = append(results, found)

src/apps/chifra/internal/chunks/handle_truncate.go

@@ -39,7 +39,7 @@ func (opts *ChunksOptions) HandleTruncate(blockNums []base.Blknum) error {
 	_ = file.CleanFolder(chain, config.PathToIndex(chain), []string{"ripe", "unripe", "maps", "staging"})
 
 	bar := logger.NewBar(logger.BarOptions{
-		Enabled: !testMode && !logger.IsTerminal(),
+		Enabled: !testMode, // && !logger.IsTerminal(),
 		Total:   128,
 		Type:    logger.Expanding,
 	})

src/apps/chifra/pkg/config/config.go

@@ -13,7 +13,9 @@ import (
 	"strings"
 	"sync"
 
+	"github.com/TrueBlocks/trueblocks-core/src/apps/chifra/pkg/logger"
 	"github.com/TrueBlocks/trueblocks-core/src/apps/chifra/pkg/usage"
+	"github.com/TrueBlocks/trueblocks-core/src/apps/chifra/pkg/utils"
 	"github.com/TrueBlocks/trueblocks-core/src/apps/chifra/pkg/version"
 	"github.com/spf13/viper"
 )
@@ -132,6 +134,9 @@ func GetRootConfig() *ConfigFile {
 		ch.LocalExplorer = clean(ch.LocalExplorer)
 		ch.RemoteExplorer = clean(ch.RemoteExplorer)
 		ch.RpcProvider = strings.Trim(clean(ch.RpcProvider), "/") // Infura, for example, doesn't like the trailing slash
+		if err := validateRpcEndpoint(ch.Chain, ch.RpcProvider); err != nil {
+			logger.Fatal(err)
+		}
 		ch.IpfsGateway = clean(ch.IpfsGateway)
 		if ch.Scrape.AppsPerChunk == 0 {
 			settings := ScrapeSettings{
@@ -201,3 +206,36 @@ func pathFromXDG(envVar string) (string, error) {
 
 	return filepath.Join(xdg, "") + "/", nil
 }
+
+func validateRpcEndpoint(chain, provider string) error {
+	if utils.IsPermitted() {
+		return nil
+	}
+
+	if provider == "https:" {
+		problem := `No rpcProvider found.`
+		return usage.Usage(rpcWarning, chain, provider, problem)
+	}
+
+	if !strings.HasPrefix(provider, "http") {
+		problem := `Invalid rpcProvider found (must be a url).`
+		return usage.Usage(rpcWarning, chain, provider, problem)
+	}
+
+	return nil
+}
+
+var rpcWarning string = `
+We found a problem with the rpcProvider for the {0} chain.
+
+	Provider: {1}
+	Chain:    {0}
+	Problem:  {2}
+
+Confirm the value for the given provider. You may edit this value with
+"chifra config edit".
+
+Also, try the following curl command. If this command does not work, neither will chifra.
+
+curl -X POST -H "Content-Type: application/json" --data '{ "jsonrpc": "2.0", "method": "web3_clientVersion", "id": 6 }' {1}
+`

src/apps/chifra/pkg/manifest/download.go

@@ -39,6 +39,11 @@ func ReadUnchainedIndex(chain string, publisher base.Address, database string) (
 
 	unchainedChain := "mainnet" // the unchained index is on mainnet
 	conn := rpc.TempConnection(unchainedChain)
+	// if conn.LatestBlockTimestamp < 1_705_173_443 { // block 19_000_000
+	// 	provider := config.GetChain(unchainedChain).RpcProvider
+	// 	logger.Fatal(usage.Usage(unchainedWarning, provider))
+	// }
+
 	theCall := fmt.Sprintf("manifestHashMap(%s, \"%s\")", publisher, database)
 	if contractCall, _, err := call.NewContractCallWithAbi(conn, callAddress, theCall, abiMap); err != nil {
 		wrapped := fmt.Errorf("the --call value provided (%s) was not found: %s", theCall, err)
@@ -128,3 +133,10 @@ func getUnchainedAbi() (base.Address, *abi.SelectorSyncMap, error) {
 
 	return callAddress, abiMap, nil
 }
+
+// var unchainedWarning string = `
+// The Unchained Index requires your mainnet RPC to be synced (at least to block 0x1304073 or 19000000).
+// Check the progress with the following curl command and try again later.
+
+// curl -X POST -H "Content-Type: application/json" --data '{"method":"eth_blockNumber","params":[],"id":1,"jsonrpc":"2.0"}' {0}
+// `

src/apps/chifra/pkg/rpc/get_traces.go

@@ -32,11 +32,13 @@ func (conn *Connection) GetTracesByBlockNumber(bn base.Blknum) ([]types.Trace, e
 
 	if traces, err := query.Query[[]types.Trace](conn.Chain, method, params); err != nil {
 		return []types.Trace{{
+			Action: &types.TraceAction{},
 			Result: &types.TraceResult{},
 		}}, err
 
 	} else if traces == nil || len(*traces) == 0 {
 		return []types.Trace{{
+			Action: &types.TraceAction{},
 			Result: &types.TraceResult{},
 		}}, err
 
@@ -89,11 +91,13 @@ func (conn *Connection) GetTracesByTransactionHash(txHash string, transaction *t
 
 	if traces, err := query.Query[[]types.Trace](conn.Chain, method, params); err != nil {
 		return []types.Trace{{
+			Action: &types.TraceAction{},
 			Result: &types.TraceResult{},
 		}}, err
 
 	} else if traces == nil || len(*traces) == 0 {
 		return []types.Trace{{
+			Action: &types.TraceAction{},
 			Result: &types.TraceResult{},
 		}}, err
 

src/apps/chifra/pkg/rpc/get_traces_parts.go

@@ -24,6 +24,7 @@ func (conn *Connection) GetTracesByTransactionId(bn base.Blknum, txid base.Txnum
 	tx, err := conn.GetTransactionByNumberAndId(bn, txid)
 	if err != nil {
 		return []types.Trace{{
+			Action: &types.TraceAction{},
 			Result: &types.TraceResult{},
 		}}, err
 	}

src/apps/chifra/pkg/rpc/get_transaction.go

@@ -354,9 +354,13 @@ func (conn *Connection) getTransactionFromRpc(blkHash base.Hash, txHash base.Has
 	}
 
 	if trans, err := query.Query[types.Transaction](conn.Chain, method, params); err != nil {
-		return &types.Transaction{}, err
+		return &types.Transaction{
+			Receipt: &types.Receipt{},
+		}, err
 	} else if trans.Hash.IsZero() {
-		return &types.Transaction{}, ethereum.NotFound
+		return &types.Transaction{
+			Receipt: &types.Receipt{},
+		}, ethereum.NotFound
 	} else {
 		return trans, nil
 	}

src/apps/chifra/pkg/utils/is_permitted.go

@@ -0,0 +1,35 @@
+package utils
+
+import "os"
+
+func IsPermitted() bool {
+	isStatus := false
+	isConfig := false
+	hasPaths := false
+	hasEdit := false
+	cnt := len(os.Args)
+	for _, arg := range os.Args {
+		if arg == "help" {
+			return false
+		} else if arg == "status" {
+			isStatus = true
+		} else if arg == "config" {
+			isConfig = true
+		} else if arg == "--paths" {
+			hasPaths = true
+		} else if arg == "edit" {
+			hasEdit = true
+		} else if arg != "--verbose" {
+			isStatus = false
+			isConfig = false
+		} else {
+			cnt-- // allow --verbose
+		}
+	}
+
+	if isStatus && cnt == 2 {
+		return true
+	}
+
+	return isConfig && (hasPaths || hasEdit) && cnt < 4
+}