Moved linter job to build workflow #3131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dszlachta
force-pushed
the
workflow/linter
branch
9 times, most recently
from
f55e8d5 to
9f645b0
Compare
dszlachta
force-pushed
the
workflow/linter
branch
3 times, most recently
from
840b9f0 to
4a47280
Compare
dszlachta
force-pushed
the
workflow/linter
branch
from
39ef7bf to
beb1d04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make lintso that it also usesgolangci-lint(you might need to install it locally withbrew)Linter in this configuration complained only about ignored errors, so I've fixed it by replacing
FuncReturningErr()with_ = FuncReturningErr(). I think it's better because it shows that there might be an error that we ignore. If you don't like it, we cangit revert beb1d04983b8c16c1a6b66f2ee4812d8b5287044