Begins forcing access to the RPC through an object #3113
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're going to make all access to the RPC go through an object (maybe called the Provider?) This will have a lot of benefits:
options.go
, so that by the time to execution gets toValidate
and then theHandlers
, we know we have a connection,opts
structures for each tool. In this way, we no longer have to pass it around through the function interfaces. This makes the code much easier to read. This has the benefit that every handler automatically has caching which was not true previously, for example.nil
rpcOptions
object which was creeping into the code.