Feature/improve rpc client package #3111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e a lint warning and be more consistent
…rnal package where it's used.
…ange to the way provider works
…n to be more consistent
…ange to the way provider works
…cate change, but straighforward
… it from rpc to rpcClient to be more consistent
…mpleTransaction which is more clear
…eFunction. Cleans up docs and usage
…nd moves it to rpcClient package
…vider(chain)/GetClient(provider)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This massive PR doesn't really change anything (as you can see nearly no test cases were modified). What it does change, though, is the cleanliness and ease of understanding for the
rpcClientandrpcpackages (and removes a number of subservient packages such asensand parts ofabithat were more correctly should have been included in therpcClientpackage.This PR is really only in preparation for a forthcoming PR that will change all access to the RPC to be access through an object (called something like
clientor something). This will allow top level code to do all sorts of things including control the cache much better (from everywhere, not just the point of calls into therpcClientpackage.We can also build in thing such as API rate limits that can be read from a config file and also API keys if (and when) we start supporting remote access to the RPC.
Also, this will allow us to initialize access to the RPC earlier in the life cycle of the
Handlerroutines (when initialized). In this way, the calling code can always assume that if the routine has gotten into theHandlerit has a properly configured RPC endpoint.That above-mentioned further PR will be added before release of version 1.0.0.