Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/port state call #2972

Merged
merged 15 commits into from
Jun 17, 2023
Merged

Feature/port state call #2972

merged 15 commits into from
Jun 17, 2023

Conversation

dszlachta
Copy link
Contributor

@dszlachta dszlachta commented Jun 9, 2023

  • New syntax for chifra state --call:
    • whole data parameter, encoded (useful for pasting from chain data when debugging): 0xcdba2fd40000000000000000000000000000000000000000000000000000000000007a69
    • four-byte followed by arguments (useful when the user doesn't know the name): 0xcdba2fd4(31337)
    • Solidity-like (useful for humans): manifestHashMap(0xf503017d7baf7fbc0fff7492b751025c6a78179b, "mainnet")
  • Function outputs are articulated using articulation package (same as ABIs)
  • Compressed results field in CSV/TSV is created using common compressed code. I've also removed it from JSON format, like we did for ABIs
  • --proxy_for is supported
  • The test getState_not_call_and_addrs is disabled, because we expect an address to be used with --call (we can support multiple addresses in the future)
  • api/getState_contract_call_fail3.txt was handled better in C++, but when we finish porting chifra state, the problem will disappear

@dszlachta dszlachta requested a review from tjayrush June 9, 2023 16:50
@dszlachta dszlachta force-pushed the feature/port_state_call branch from 0573690 to 7cbbc26 Compare June 14, 2023 13:02
@dszlachta dszlachta marked this pull request as ready for review June 16, 2023 11:41
@tjayrush
Copy link
Member

I'm going to merge this, and then write three or four issues (and fix those issues) and make a PR.

Because all my issues will be cosmetic, I won't wait for your review of that PR (I need --call to do pricing for accounting).

I'll make my changes simple and easy to review.

@tjayrush tjayrush merged commit ff4dd58 into develop Jun 17, 2023
@tjayrush tjayrush deleted the feature/port_state_call branch June 17, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants