-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/port state call #2972
Merged
Merged
Feature/port state call #2972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0573690
to
7cbbc26
Compare
I'm going to merge this, and then write three or four issues (and fix those issues) and make a PR. Because all my issues will be cosmetic, I won't wait for your review of that PR (I need I'll make my changes simple and easy to review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chifra state --call
:0xcdba2fd40000000000000000000000000000000000000000000000000000000000007a69
0xcdba2fd4(31337)
manifestHashMap(0xf503017d7baf7fbc0fff7492b751025c6a78179b, "mainnet")
Compressed results
field in CSV/TSV is created using commoncompressed
code. I've also removed it fromJSON
format, like we did for ABIs--proxy_for
is supportedgetState_not_call_and_addrs
is disabled, because we expect an address to be used with--call
(we can support multiple addresses in the future)api/getState_contract_call_fail3.txt
was handled better in C++, but when we finish portingchifra state
, the problem will disappear