Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/names clean reporting tests #2944

Merged
merged 3 commits into from
May 29, 2023
Merged

Bugfix/names clean reporting tests #2944

merged 3 commits into from
May 29, 2023

Conversation

dszlachta
Copy link
Contributor

This PR:

  1. Fixes chifra names --clean reports badly #2941 by properly cleaning the line after \r (new function to do it: logger.CleanLine()) and adding these messages:
INFO[29-05|16:26:16.522] Writing results to /Users/xxx/Library/Application Support/TrueBlocks/config/mainnet/names.tab
INFO[29-05|16:33:38.737] The regular names database was cleaned. 116 name(s) has been modified
  1. Sets a specific block number for testing totalSupply in token_integration_test.go

@dszlachta dszlachta requested a review from tjayrush May 29, 2023 14:56
@tjayrush tjayrush merged commit db7f89d into develop May 29, 2023
@tjayrush tjayrush deleted the bugfix/names_clean_reporting_tests branch May 29, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjayrush tjayrush Awaiting requested review from tjayrush

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dszlachta @tjayrush