Store metadata in sqlite #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The abstraction is not good, the code is buggy. But it will do until it is re-done to use the SQL database.
Before, Trow used the filesystem as a database. Now it have an SQlite DB. Will allow advanced features like LRU cache of images.
|
I still have some OCI conformance issues, I'm gonna fix these in a following pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Big changes !
I plan on testing and stabilizing this for a while before releasing. Next feature: LRU cache !
Fixes #391
Fixes #145
For #145, I too wanted some sort of CRDT But I just don't have the bandwidth.
Note that there are 2 ways ahead for HA:
I think 2 is more feasible