rework U32 Table #181
Merged
rework U32 Table #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-ferdinand
force-pushed
the
u32_v2
branch
2 times, most recently
from
03134a6 to
ded1b98
Compare
jan-ferdinand
force-pushed
the
u32_v2
branch
from
a500e15 to
b9c2e65
Compare
aszepieniec
approved these changes
Feb 17, 2023
- use one `Result` column, don't compute every possible result - allow arbitrary field elements as the base for instruction `pow` - tests for instruction `pow`: take arbitrary field elements as base
- use Daniel Lubarov's trick to convert from result of `and` to `xor` - consequently, remove U32 Table's “awareness” of instruction `xor` - also: enforce `RHS` being 0 for instruction `log_2_floor` only once
jan-ferdinand
force-pushed
the
u32_v2
branch
from
b9c2e65 to
a0c2681
Compare
jan-ferdinand
added a commit
that referenced
this pull request
Mar 10, 2023
- change instructions `read_mem` and `write_mem` (#179) (022245b) - `read_mem` now pushes to stack instead of overwriting - `write_mem` now pops the written element from stack - move to Tip5 hash function (#161) (#182) (d40f0b6) - this greatly boosts overall prover performance - replace Instruction Table by Lookup Argument (#171) (543327a) - rework U32 Table (#181) (09a4c27) - link to processor using Lookup Argument (2719030) - improve clock jump differences check (#177) (04bb5c4 and 9c2f3c0) - improve parsing of Triton assembly - remove old parser (bbe4aa8) - introduce `ParsedInstruction`, simplifying parsing (8602892) - fix bug in property test (9e4fcb7) - improve on constant folding in multicircuits (#183) (c1be5bb) - update to twenty-first v0.18 (#184) (ff972ff) - improve specification and documentation - explain the various cross-table arguments (567efc0) - more and better links (a66b20d and 9386878) - various simplifications and readability improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resultcolumn, don't compute every possible resultpowandtoxortrick