-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Credit mining (tests) are dependent on GUI code (GUIDBTuples) #2356
Comments
It also has dependency with the managers, for example: |
@ardhipoetra that depends on what you need from the |
basically, all the process from having only the infohash, to really get the torrent file, store it to torrent_store or database, and an object representation of a torrent. I need In any case, I'm looking at it now. |
@ardhipoetra how much work would it be to create a minimal method for that in |
I'm finishing it right now and it in the testing phase EDIT : it's there! :) |
Closes Tribler#2356 Squashed : - Refactor to use deferred
This issue should be close by the #2398 |
Closes Tribler#2356 Squashed : - Refactor to use deferred
During the removal of the wx code, I found out that the credit mining tests (in particular,
test_creditmining_sys.py
are dependent on the (soon to be removed)GuiDbTuples
package. See for instancetest_chn_lookup
where you are usingCollectedTorrent
.A quick search learned me that the
GuiDbTuples
package is also used inBoostingSource.py
andcredit_mining_util.py
.@ardhipoetra can you refactor this so they are not using
GuiDbTuples
as soon as possible?The text was updated successfully, but these errors were encountered: