Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credit mining (tests) are dependent on GUI code (GUIDBTuples) #2356

Closed
devos50 opened this issue Jun 29, 2016 · 6 comments
Closed

Credit mining (tests) are dependent on GUI code (GUIDBTuples) #2356

devos50 opened this issue Jun 29, 2016 · 6 comments
Assignees
Milestone

Comments

@devos50
Copy link
Contributor

devos50 commented Jun 29, 2016

During the removal of the wx code, I found out that the credit mining tests (in particular, test_creditmining_sys.py are dependent on the (soon to be removed) GuiDbTuples package. See for instance test_chn_lookup where you are using CollectedTorrent.

A quick search learned me that the GuiDbTuples package is also used in BoostingSource.py and credit_mining_util.py.

@ardhipoetra can you refactor this so they are not using GuiDbTuples as soon as possible?

@devos50 devos50 changed the title Credit mining tests are dependent on GUI code (GUIDBTuples) Credit mining (tests) are dependent on GUI code (GUIDBTuples) Jun 29, 2016
@whirm whirm added this to the New GUI milestone Jun 29, 2016
@ardhipoetra
Copy link

ardhipoetra commented Jun 29, 2016

It also has dependency with the managers, for example: TorrentManager (in Main/vwxGUI/SearchGridManager.py). Is there any module to replace that now?

@devos50
Copy link
Contributor Author

devos50 commented Jun 29, 2016

@ardhipoetra that depends on what you need from the TorrentManager. Can you explain that?

@ardhipoetra
Copy link

basically, all the process from having only the infohash, to really get the torrent file, store it to torrent_store or database, and an object representation of a torrent.

I need ChannelManager as well, but I think I have workaround for that.

In any case, I'm looking at it now.

@devos50
Copy link
Contributor Author

devos50 commented Jun 30, 2016

@ardhipoetra how much work would it be to create a minimal method for that in Session or LaunchManyCores (or some other file)?

@ardhipoetra
Copy link

ardhipoetra commented Jul 2, 2016

I'm finishing it right now and it in the testing phase

EDIT : it's there! :)

ardhipoetra added a commit to ardhipoetra/tribler that referenced this issue Jul 2, 2016
ardhipoetra added a commit to ardhipoetra/tribler that referenced this issue Jul 2, 2016
ardhipoetra added a commit to ardhipoetra/tribler that referenced this issue Sep 15, 2016
ardhipoetra added a commit to ardhipoetra/tribler that referenced this issue Oct 18, 2016
Closes Tribler#2356

Squashed :
- Refactor to use deferred
@ardhipoetra
Copy link

This issue should be close by the #2398

@devos50 devos50 closed this as completed Oct 19, 2016
devos50 pushed a commit to devos50/tribler that referenced this issue Jan 12, 2017
Closes Tribler#2356

Squashed :
- Refactor to use deferred
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants