Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TrustChain validation, refactor packet serialization #9

Merged
merged 4 commits into from
Feb 22, 2020

Conversation

MattSkala
Copy link
Collaborator

  • Add block public key and signature validation
  • Add chain consistency validation
  • Refactor packet serialization to reduce boilerplate
  • Store WAN and LAN address for verified peers for more reliable LAN introduction

@codecov
Copy link

codecov bot commented Feb 22, 2020

Codecov Report

Merging #9 into master will increase coverage by 0.56%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master       #9      +/-   ##
============================================
+ Coverage     75.88%   76.45%   +0.56%     
- Complexity      438      465      +27     
============================================
  Files            53       54       +1     
  Lines          1783     1792       +9     
  Branches        225      239      +14     
============================================
+ Hits           1353     1370      +17     
+ Misses          293      276      -17     
- Partials        137      146       +9     
Impacted Files Coverage Δ Complexity Δ
...in/java/nl/tudelft/ipv8/keyvault/CryptoProvider.kt 66.66% <0.00%> (ø) 0.00% <0.00%> (?%)
...ipv8/attestation/trustchain/TrustChainCommunity.kt 34.06% <0.00%> (+0.59%) 33.00% <0.00%> (+2.00%) ⬇️
ipv8/src/main/java/nl/tudelft/ipv8/Community.kt 78.45% <0.00%> (-0.05%) 52.00% <0.00%> (+7.00%)
...lft/ipv8/attestation/trustchain/TrustChainBlock.kt 64.96% <0.00%> (+0.20%) 45.00% <0.00%> (+13.00%) ⬇️
ipv8/src/main/java/nl/tudelft/ipv8/IPv8.kt 74.00% <0.00%> (+6.00%) 9.00% <0.00%> (+1.00%) ⬇️
.../src/main/java/nl/tudelft/ipv8/messaging/Packet.kt 92.00% <0.00%> (+32.00%) 7.00% <0.00%> (+2.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6dd432...625136f. Read the comment docs.

@MattSkala MattSkala merged commit d5384ab into master Feb 22, 2020
@MattSkala MattSkala deleted the update-tc-validation branch February 24, 2020 14:49
jverbraeken pushed a commit to jverbraeken/kotlin-ipv8 that referenced this pull request Dec 22, 2020
Update TrustChain validation, refactor packet serialization
InvictusRMC added a commit that referenced this pull request Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant