Fixup for change to find_package(Python3) (#610) #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When changing to find_package(Python3) (see #610), the variable PYTHON_VERSION_MAJOR no longer gets set. That caused HAS_PYTHON3 to get set to FALSE and for the test TriBITS_sphinx_rst_generator_UnitTests to not get enabled (but is actually disabled using property DISABLED). NOTE: The CDash feature that reports when tests go missing caught this problem! (I never noticed that when doing local testing). Here is what that CDash email looked like: ---- Summary: [tribits-checkins] FAILED (m=1): TriBITS/TriBITS - tribits_cmake-3.25.2_makefiles_python-3.8_g++-11 - Continuous A submission to CDash for the project TriBITS has missing tests. You have been identified as one of the authors who have checked in changes that are part of this submission or you are listed in the default contact list. Details on the submission can be found at https://my.cdash.org/build/2685504. Project: TriBITS SubProject: TriBITS Site: ubuntu-latest Build Name: tribits_cmake-3.25.2_makefiles_python-3.8_g++-11 Build Time: 2024-10-09 16:55:55 Type: Continuous Total Missing Tests: 1 *Missing Tests* TriBITS_sphinx_rst_generator_UnitTests (https://my.cdash.org/viewTest.php?buildid=2685505) -CDash ---- That is such a nice feature!
rabartlett1972
previously approved these changes
Oct 9, 2024
…UTABLE (#610) This typo did not get discovered on the PR review that added this.
bartlettroscoe
force-pushed
the
610-python3-2
branch
from
1287e72 to
23135a9
Compare
Now this is safer to run on a project's entire source tree and it is documented to explain what this is for.
bartlettroscoe
changed the title
rabartlett1972
approved these changes
Oct 10, 2024
There was a problem hiding this comment.
I fixed some problems not found in the review of #616. I need a few days to review something that I have written.
bartlettroscoe
added a commit
to trilinos/Trilinos
that referenced
this pull request
Oct 10, 2024
Origin repo remote tracking branch: 'github/master' Origin repo remote repo URL: 'github = [email protected]:TriBITSPub/TriBITS.git' Git describe: tribits_start-3502-g28a36351 At commit: commit 3dca096437acbb7a16b88bee7d9569bccd8e6317 Author: Samuel E. Browne <[email protected]> Date: Thu Jun 6 15:26:15 2024 -0600 Summary: Add Python3 requirement to user guide (#610) Mostly, this was done to brings in the changes for transitioning to find_package(Python3) (see TriBITSPub/TriBITS#610). But the full set of TriBITS PRs merged in were: * TriBITSPub/TriBITS#608 sebrowne/python3 * TriBITSPub/TriBITS#617 TriBITSPub/610-python3-2 * TriBITSPub/TriBITS#616 bartlettroscoe/610-python3 * TriBITSPub/TriBITS#615 bartlettroscoe/enable-disable-doc-update-2024-08-29 * TriBITSPub/TriBITS#611 bartlettroscoe/tril-13133-TriBITS-Update-License-and-Copyright-2 * TriBITSPub/TriBITS#614 bartlettroscoe/tribits-updates-2024-08-01 * TriBITSPub/TriBITS#613 TriBITSPub/612-improve-tribits-version-error * TriBITSPub/TriBITS#609 bartlettroscoe/tril-13133-TriBITS-Update-License-and-Copyright
bartlettroscoe
added a commit
to bartlettroscoe/Trilinos
that referenced
this pull request
Oct 11, 2024
Origin repo remote tracking branch: 'github/master' Origin repo remote repo URL: 'github = [email protected]:TriBITSPub/TriBITS.git' Git describe: tribits_start-3502-g28a36351 At commit: commit 3dca096437acbb7a16b88bee7d9569bccd8e6317 Author: Samuel E. Browne <[email protected]> Date: Thu Jun 6 15:26:15 2024 -0600 Summary: Add Python3 requirement to user guide (trilinos#610) Mostly, this was done to brings in the changes for transitioning to find_package(Python3) (see TriBITSPub/TriBITS#610). But the full set of TriBITS PRs merged in were: * TriBITSPub/TriBITS#608 sebrowne/python3 * TriBITSPub/TriBITS#617 TriBITSPub/610-python3-2 * TriBITSPub/TriBITS#616 bartlettroscoe/610-python3 * TriBITSPub/TriBITS#615 bartlettroscoe/enable-disable-doc-update-2024-08-29 * TriBITSPub/TriBITS#611 bartlettroscoe/tril-13133-TriBITS-Update-License-and-Copyright-2 * TriBITSPub/TriBITS#614 bartlettroscoe/tribits-updates-2024-08-01 * TriBITSPub/TriBITS#613 TriBITSPub/612-improve-tribits-version-error * TriBITSPub/TriBITS#609 bartlettroscoe/tril-13133-TriBITS-Update-License-and-Copyright Signed-off-by: Roscoe A. Bartlett <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits and commit messages for details