Change cmake_minimum_required() to upper bound TRIBITS_CMAKE_MINIMUM_REQUIRED (#522) #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…REQUIRED (TriBITSPub#522) This was changed from the open-ended ${CMAKE_VERSION}. This way, we allow CMake to use a more current set of policies while not writting future futures of CMake a blank check. This change was made based on feedback from @KyleFromKitware from the post-merge review of TriBITSPub#523. NOTE: I manaully tested this with a configure of Trilinos and it produded: cmake_minimum_required(VERSION 3.3...3.17.0)
rabartlett1972
approved these changes
Aug 25, 2022
There was a problem hiding this comment.
This change was approved by @KyleFromKitware in #523 (comment).
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit log msg for details.
Should complete the work for #522 based on feedback from review of PR #523.