Make install DESTINATION relative for stuff #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlettroscoe
force-pushed
the
withsubpackagesb-install-stuff-rel
branch
from
78c534f to
55ead86
Compare
This allows things like: cmake --install . --prefix <install-prefix> to work correctly.
bartlettroscoe
force-pushed
the
withsubpackagesb-install-stuff-rel
branch
from
55ead86 to
7ff4ee3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes:
work correctly.
Turns out that install rules should be defined carefully so that
install( ... DESTINATION <dest> ... )is relative when possible (unless someone overrides this explicitly).I tested this manually and with this change, everything in TribitsExampleProject seemed to install under the new
<install-prefix>correctly.