Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make package export files more modular #1

Closed
nschloe opened this issue Sep 5, 2014 · 7 comments
Closed

make package export files more modular #1

nschloe opened this issue Sep 5, 2014 · 7 comments

Comments

@nschloe
Copy link
Contributor

nschloe commented Sep 5, 2014

Right now, linking information is stored in the project target file, e.g., TrilinosTargets.cmake where all packages of the project is gathered. This target file is then sourced from all package export config files as

# Import Trilinos targets                                                       
IF(NOT Trilinos_TARGETS_IMPORTED)                                               
  SET(Trilinos_TARGETS_IMPORTED 1)                                              
  INCLUDE("${CMAKE_CURRENT_LIST_DIR}/../Trilinos/TrilinosTargets.cmake")        
ENDIF()

(with the example being Trilinos here). This layout tightly ties together all export files of the project and makes it hard to use the export file of a (sub)package individually.

By

  • exporting target files for each package individually,
  • removing the project target file, and
  • importing from each package only the dependent packages,

the currently functionality is exactly preserved, it will be possible to treat each package (with its dependencies) individually, and FIND_PACKAGE(<package_name>) will be allowed in applications.

@bartlettroscoe bartlettroscoe added this to the 1_backlog milestone Sep 5, 2014
@bartlettroscoe
Copy link
Member

We will put this into the backlog for now.

@bartlettroscoe
Copy link
Member

Sorry, did not mean to "close".

@nschloe
Copy link
Contributor Author

nschloe commented Sep 11, 2014

I have a branch ready for this, but it doesn't seem to work quite yet with the STK/SEACAS integration. Not sure yet where the bug lies.

@bartlettroscoe
Copy link
Member

Okay, so now that TriBITS requires CMake 2.8.11 and now that SEACAS has fixed their usage of SUBDIRS(), we can push #11?

@nschloe
Copy link
Contributor Author

nschloe commented Sep 24, 2014

There are no tests for the export files yet; I suppose we should merge those in first. Otherwise LGTM.

@bartlettroscoe
Copy link
Member

Is this not already resolved now that I have pushed you untangle_export_files branch?

@nschloe
Copy link
Contributor Author

nschloe commented Sep 25, 2014

Indeed it is.

@nschloe nschloe closed this as completed Sep 25, 2014
@bartlettroscoe bartlettroscoe removed this from the 1_backlog milestone Sep 26, 2014
@bartlettroscoe bartlettroscoe modified the milestone: 6_deployed Oct 13, 2014
bartlettroscoe pushed a commit that referenced this issue Jan 19, 2021
…ptions-1

Adds cdash_analyze_and_report.py --filter-out-builds-and-tests-not-matching-expected-builds, fix filtering
mzuzek pushed a commit to mzuzek/TriBITS that referenced this issue Mar 21, 2022
…dvanced_typo_fixes

Fixed typo mistake seen in PR 464
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants