Skip to content

Commit

Permalink
Add changelog not for setting <Package>_ENABLE_<depPkg> for required …
Browse files Browse the repository at this point in the history
…deps (#63, #299)

This breaks at least one Trilinos package Isorropia.
  • Loading branch information
bartlettroscoe committed May 17, 2022
1 parent 5d1026d commit 630d877
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions tribits/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,16 @@ ChangeLog for TriBITS
technically a break in backward compatibility, but not for well-formed
TriBITS projects.

* **Changed:** Variables `${PACKAGE_NAME}_ENABLE_<depPkg>` are now set to
`TRUE` for required upstream internal and external packages/TPLs (in order
to simplify internal logic). However, a side effect of this is that that
was ifed out with an incorrect `if (${PACKAGE_NAME}_ENABLE_<depPkg>)`
statement for a required upstream dependency `<depPkg>` will now be enabled.
(This mistake can happen when an optional dependency `<depPkg>` is changed
to a required dependency but the `if()` statements based on
`${PACKAGE_NAME}_ENABLE_<depPkg>` are not removed. (Well-formed TriBITS
projects and packages should not experience any change.)

## 2022-05-16:

* **Added:** The function `tribits_add_advanced_test(`) now correctly accepts
Expand Down

0 comments on commit 630d877

Please sign in to comment.