Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Align): add component, demo, docs #544

Merged
merged 2 commits into from
Dec 10, 2024
Merged

feat(Align): add component, demo, docs #544

merged 2 commits into from
Dec 10, 2024

Conversation

andretchen0
Copy link
Contributor

Ports Drei's <Center /> to Cientos as <Align />. Adds:

  • component
  • demo
  • docs

@andretchen0 andretchen0 added the feature New feature or request label Nov 29, 2024
@andretchen0 andretchen0 marked this pull request as ready for review November 29, 2024 06:06
Copy link

netlify bot commented Nov 29, 2024

Deploy Preview for cientos-tresjs ready!

Name Link
🔨 Latest commit 34e00d1
🔍 Latest deploy log https://app.netlify.com/sites/cientos-tresjs/deploys/6758a071375ed90008a3d9ab
😎 Deploy Preview https://deploy-preview-544--cientos-tresjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@andretchen0
Copy link
Contributor Author

@alvarosabu

I called this <Align> instead of <Center> (like Drei). Thoughts?

For context, it puts all child elements in a Box3, then aligns the box to the origin. It doesn't align the children individually, which "align" might suggest.

So, "align" isn't perfect, but I thought maybe it was better than "center".

@alvarosabu alvarosabu added the p3-significant High-priority enhancement (priority) label Dec 10, 2024
Copy link
Member

@alvarosabu alvarosabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andretchen0 I think align is the correct name for the nature of the component

Copy link

pkg-pr-new bot commented Dec 10, 2024

Open in Stackblitz

npm i https://pkg.pr.new/@tresjs/cientos@544

commit: 34e00d1

@alvarosabu alvarosabu merged commit e3ee52c into main Dec 10, 2024
8 checks passed
@andretchen0 andretchen0 deleted the feat/align branch December 11, 2024 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request p3-significant High-priority enhancement (priority)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants