Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SoftShadows): add component, demo, docs #541

Merged
merged 5 commits into from
Dec 10, 2024
Merged

Conversation

andretchen0
Copy link
Contributor

@andretchen0 andretchen0 commented Nov 27, 2024

Ports THREE's/Drei's <SoftShadows /> to Cientos. Adds:

  • component
  • demo
  • docs

Closes #322

Copy link

netlify bot commented Nov 27, 2024

Deploy Preview for cientos-tresjs ready!

Name Link
🔨 Latest commit 49ec8a3
🔍 Latest deploy log https://app.netlify.com/sites/cientos-tresjs/deploys/675871d1cbc00a00086554db
😎 Deploy Preview https://deploy-preview-541--cientos-tresjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@andretchen0 andretchen0 marked this pull request as ready for review November 27, 2024 10:33
@andretchen0 andretchen0 added feature New feature or request p3-significant High-priority enhancement (priority) labels Nov 27, 2024
Copy link

pkg-pr-new bot commented Nov 27, 2024

Open in Stackblitz

npm i https://pkg.pr.new/@tresjs/cientos@541

commit: 49ec8a3

Copy link
Member

@alvarosabu alvarosabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @andretchen0 I am so happy to see this one, I had it on my list a long time ago.

I'm experiencing some artifacts on the shadows on the playground if I resize the window in comparison with the Drei implementation. But not sure if it's fixable

Screen.Recording.2024-12-09.at.12.38.48.mov
Screen.Recording.2024-12-09.at.12.39.27.mov

@andretchen0
Copy link
Contributor Author

andretchen0 commented Dec 10, 2024

Hi @andretchen0 I am so happy to see this one, I had it on my list a long time ago.

I'm experiencing some artifacts on the shadows on the playground if I resize the window in comparison with the Drei implementation. But not sure if it's fixable
Screen.Recording.2024-12-09.at.12.38.48.mov
Screen.Recording.2024-12-09.at.12.39.27.mov

I hooked up the samples prop to a sine wave. When samples is low, the shadows have a lot of artifacts.

My bad. I'll add a proper interactive menu to the playground instead.

@alvarosabu alvarosabu merged commit e71cdad into main Dec 10, 2024
8 checks passed
@andretchen0 andretchen0 deleted the feat/soft-shadows branch December 11, 2024 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request p3-significant High-priority enhancement (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SoftShadows component
2 participants