Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ScreenSizer): add component, playground, docs #535

Merged
merged 3 commits into from
Dec 4, 2024
Merged

feat(ScreenSizer): add component, playground, docs #535

merged 3 commits into from
Dec 4, 2024

Conversation

andretchen0
Copy link
Contributor

Ports Drei's <ScreenSizer /> to Cientos. Adds:

  • component
  • demo
  • docs

@andretchen0 andretchen0 added the feature New feature or request label Nov 23, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 23, 2024 •
edited
Loading

✅ Deploy Preview for cientos-tresjs ready!

Name Link
🔨 Latest commit 4a2a70d
🔍 Latest deploy log https://app.netlify.com/sites/cientos-tresjs/deploys/67508c3e2a264f0008d4dd2a
😎 Deploy Preview https://deploy-preview-535--cientos-tresjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@andretchen0 andretchen0 marked this pull request as ready for review November 23, 2024 23:58
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Dec 4, 2024 •
edited
Loading

Open in Stackblitz

npm i https://pkg.pr.new/@tresjs/cientos@535

commit: 4a2a70d

alvarosabu
alvarosabu approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@alvarosabu alvarosabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andretchen0 these screen abstractions are really funny but cool.

I just added the demo to the routes

@alvarosabu alvarosabu added the p3-significant High-priority enhancement (priority) label Dec 4, 2024
@alvarosabu alvarosabu merged commit ee5af96 into main Dec 4, 2024
7 of 8 checks passed
@andretchen0 andretchen0 deleted the feat/screen-sizer branch December 6, 2024 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarosabu alvarosabu alvarosabu approved these changes

Assignees
No one assigned
Labels
feature New feature or request p3-significant High-priority enhancement (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andretchen0 @alvarosabu