Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Outline): add component, demo, docs #532

Merged
merged 8 commits into from
Dec 4, 2024
Merged

feat(Outline): add component, demo, docs #532

merged 8 commits into from
Dec 4, 2024
+286 −15

Conversation

andretchen0
Copy link
Contributor

@andretchen0 andretchen0 commented Nov 23, 2024 •
edited
Loading

Port of Drei's <Outline />. Adds:

  • component
  • demo
  • docs

@netlify Netlify
Copy link

netlify bot commented Nov 23, 2024 •
edited
Loading

✅ Deploy Preview for cientos-tresjs ready!

Name Link
🔨 Latest commit 0c1fe91
🔍 Latest deploy log https://app.netlify.com/sites/cientos-tresjs/deploys/675010e844f6bb0008c4b646
😎 Deploy Preview https://deploy-preview-532--cientos-tresjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@andretchen0 andretchen0 changed the title Outline feat(Outline): add component, demo Nov 23, 2024
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Nov 23, 2024 •
edited
Loading

Open in Stackblitz

npm i https://pkg.pr.new/@tresjs/cientos@532

commit: 0c1fe91

@andretchen0 andretchen0 changed the title feat(Outline): add component, demo feat(Outline): add component, demo, docs Nov 23, 2024
@andretchen0 andretchen0 marked this pull request as ready for review November 23, 2024 08:50
@alvarosabu alvarosabu changed the title feat(Outline): add component, demo, docs feat(outline): add component, demo, docs Nov 23, 2024
@alvarosabu alvarosabu self-assigned this Nov 23, 2024
@alvarosabu alvarosabu added feature New feature or request p3-significant High-priority enhancement (priority) labels Nov 23, 2024
@andretchen0 andretchen0 changed the title feat(outline): add component, demo, docs feat(Outline): add component, demo, docs Nov 24, 2024
alvarosabu
alvarosabu requested changes Nov 24, 2024
View reviewed changes
Copy link
Member

@alvarosabu alvarosabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left one blocking about the shaderMaterial to deconstruct three imports

@alvarosabu alvarosabu merged commit 5bae4de into main Dec 4, 2024
8 checks passed
@andretchen0 andretchen0 deleted the feat/outline branch December 6, 2024 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarosabu alvarosabu alvarosabu approved these changes

Assignees

@alvarosabu alvarosabu

Labels
feature New feature or request p3-significant High-priority enhancement (priority)
Projects
Team Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andretchen0 @alvarosabu