Fix node mask compression #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmilioLaiso
approved these changes
Nov 10, 2023
Signed-off-by: rosaliedewinther <[email protected]>
rosaliedewinther
force-pushed
the
fix-node-mask-compression
branch
from
f25d2d2 to
acd9bd9
Compare
MarijnS95
reviewed
Nov 10, 2023
| .iter() | ||
| .by_vals() | ||
| .take(idx) | ||
| .fold(0, |old, val| old + (!val as usize)); // count 0's before idx |
There was a problem hiding this comment.
I wonder if you could have .map(|v| !v as usize).sum()'ed this 😬
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some old files only store tile values when the child bit is set to 0, so when iterating over our data we should grab the tile values by indexing into the tile buffer with an index computed by counting the number of 0 bits before the usual bit index. This fixes tile value loading of bunny_cloud.vdb