improve robustness for approvalrule.pp

[kreeuwijk]

The proposed changes will improve the robustness of the approvalrule.pp manifest. With the original code, I ran into the issue that if the WSUS server is low on memory, sometimes Get-WsusServer fails to complete. This will trip up the unless rule and make Puppet think it needs to re-apply the approval rule. This results in multiple identical copies of the same rule, which trips up other code that isn't expecting >1 result for a specific rule query.

The new code switches to onlyif to account for the occasional failure in Get-WsusServer and not have it result in duplicate rules.

[TraGicCode]

Hey,

Sorry for getting back to this so late. I will give this a review by tommorow!

[kreeuwijk]

Thanks @TraGicCode !

[TraGicCode]

LGTM and thank you!

[kreeuwijk]

Thanks! Can you republish the module on the Forge too? That way everybody can enjoy it :-) *Kevin Reeuwijk* Principal Sales Engineer, NEMEA mobile: +31 6 272 33 55 1 [email protected] <[email protected]> | @KevinReeuwijk *Puppet <http://www.puppet.com>. The shortest path to better software.*

…

On Sat, Jul 27, 2019 at 12:22 PM Michael Fyffe ***@***.***> wrote: Merged #29 <#29> into master. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#29?email_source=notifications&email_token=AGNBUR2FDLCJKBNEKYX4CQDQBQOUXA5CNFSM4H7NN2M2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOSXNVB2Y#event-2514178283>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGNBUR3FTJIEP6OIJDQBRN3QBQOUXANCNFSM4H7NN2MQ> .

[kreeuwijk]

Hi Michael, I've published a blogpost <https://puppet.com/blog/how-automate-windows-patching-puppet> on the puppet.com website that uses your wsusserver module. The example code in the blogpost uses the product_families attribute which is in v1.1.1 of your module. But that module isn't published on the Forge yet. Could you please publish this version? Thank you! *Kevin Reeuwijk* Principal Sales Engineer, NEMEA mobile: +31 6 272 33 55 1 [email protected] <[email protected]> | @KevinReeuwijk *Puppet <http://www.puppet.com>. The shortest path to better software.* J*oin us for Puppetize PDX <http://www.puppet.com/puppetize> 9-10 October.* On Tue, Jul 30, 2019 at 9:59 AM Kevin Reeuwijk <[email protected]> wrote:

…

Thanks! Can you republish the module on the Forge too? That way everybody can enjoy it :-) *Kevin Reeuwijk* Principal Sales Engineer, NEMEA mobile: +31 6 272 33 55 1 ***@***.*** ***@***.***> | @KevinReeuwijk *Puppet <http://www.puppet.com>. The shortest path to better software.* On Sat, Jul 27, 2019 at 12:22 PM Michael Fyffe ***@***.***> wrote: > Merged #29 <#29> > into master. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#29?email_source=notifications&email_token=AGNBUR2FDLCJKBNEKYX4CQDQBQOUXA5CNFSM4H7NN2M2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOSXNVB2Y#event-2514178283>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AGNBUR3FTJIEP6OIJDQBRN3QBQOUXANCNFSM4H7NN2MQ> > . >