Support for TSLint processor #65
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| private String executeTSLint(String[] commands) throws ReviewException { | ||
| try { | ||
| log.info("Running native process: " + StringUtils.join(commands, " ")); | ||
| ProcessBuilder builder = new ProcessBuilder(commands); |
There was a problem hiding this comment.
I don't think that using sputnik to execute another node process is a good idea. Maybe it's possible to just pass the output of tslint to sputnik directly (e.g. as some runtime parameter?). @SpOOnman wdyt?
|
@pjagielski it's not the best idea. We use Mozilla Rhino already but I think it won't be enough for TSLint? |
|
We finally decided to allow external tool execution. I merged your branch with master and added some abstraction over executing external commands - see #139 |
|
After one year :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.