Saas api key #134
Merged
Saas api key #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is
|
| @@ -23,9 +23,11 @@ | |||
| private static Integer SOME_PULL_REQUEST_ID = 12314; | |||
| private static String SOME_REPOSITORY = "repo"; | |||
| private static String SOME_PROJECT = "proj"; | |||
| private static String SOME_API_KEY = "my_api_key"; | |||
There was a problem hiding this comment.
[Checkstyle] ERROR: Name 'SOME_API_KEY' must match pattern '^[a-z][a-zA-Z0-9]*$'.
| private static Integer SOME_PULL_REQUEST_ID = 12314; | ||
| private static String SOME_REPOSITORY = "repo"; | ||
| private static String SOME_PROJECT = "proj"; | ||
| private final static Integer SOME_PULL_REQUEST_ID = 12314; |
There was a problem hiding this comment.
[Checkstyle] ERROR: 'static' modifier out of order with the JLS suggestions.
| @@ -9,7 +9,8 @@ | |||
| CONF("cli.conf", "Configuration properties file", null), | |||
| CHANGE_ID("cli.changeId", "Gerrit change id", null), | |||
| REVISION_ID("cli.revisionId", "Gerrit revision id", null), | |||
| PULL_REQUEST_ID("cli.pullRequestId", "Stash pull request id", null); | |||
| PULL_REQUEST_ID("cli.pullRequestId", "Stash pull request id", null), | |||
| API_KEY("cli.apiKey", "Optional API key", null); | |||
There was a problem hiding this comment.
I miss an information in description: what is this API key intended for?
|
Only one comment on my side. |
|
Documented apiKey parameter |
rufuslevi
pushed a commit
to rufuslevi/sputnik
that referenced
this pull request
Mar 12, 2024
Saas api key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.