Implement snapshot tests for identifyflats and handle NaN s
#139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/snapshot.cpp runs `identifyflats` on the various snapshot data sets. src/identifyflats.c has one small change to ensure that NaNs are handled consistently with TopoToolbox v2. Neighboring NaNs are treated as if they lie below the current pixel, but NaNs are not themselves flats. fminf ensures consistent NaN treatment, and the NaN equality semantics ensures that NaNs are never set. The sills are already handled correctly, since they are only compared to neighbors that are known to be flats. Signed-off-by: William Kearney <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #138
test/snapshot.cpp runs
identifyflatson the various snapshot data sets.src/identifyflats.c has one small change to ensure that NaNs are handled consistently with TopoToolbox v2. Neighboring NaNs are treated as if they lie below the current pixel, but NaNs are not themselves flats. fminf ensures consistent NaN treatment, and the NaN equality semantics ensures that NaNs are never set.
The sills are already handled correctly, since they are only compared to neighbors that are known to be flats.