Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reference shacl_box #107

Closed
wants to merge 1 commit into from
Closed

Conversation

justin2004
Copy link

in case people want to try this out without much fuss and they have docker installed

@HolgerKnublauch
Copy link
Collaborator

Hi, thanks for the PR. I certainly can see this is useful yet I am hesitant to put it on the main page as this is an external dependency that I am not really monitoring and don't have time to test whether it still works etc. Wouldn't the usual process be that you register this image on some public repo so that people can find it from there?

@justin2004
Copy link
Author

justin2004 commented Feb 8, 2021

that's fair.
yeah, i will eventually link my github repo with dockerhub so that dockerhub will build the image and keep it in its registry.

EDIT: i could change the README language so that it is clear this is an external dependency that isn't validated by TopQuadrant if that would help? i just wanted people to be able to test it out quickly. my team also wanted to try it out quickly as well.

@ashleycaselli
Copy link
Collaborator

See #168 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants