Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to tools for unblinding checks #320

Merged
merged 38 commits into from
Sep 21, 2022
Merged

Updates to tools for unblinding checks #320

merged 38 commits into from
Sep 21, 2022

Conversation

kmohrman
Copy link
Contributor

@kmohrman kmohrman commented Sep 8, 2022

This PR includes most of the minor updates I've been making since we began unblinding, but none of these changes should actually impact the results (i.e. they do not change our analysis pkl files, or the datacards etc., they only provide updates to our tools for the studies we've been doing since unblinding).

I don't think this PR is ready to be merged, as most of the changes are quite messy. However, I wanted to make the PR now, just so I can get an idea of what changes are included here, and clean things up when I get a chance, so that we can eventually get this into the master (since it's getting to the point where I'd like to have at least some of these updates in the master branch).

@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Merging #320 (9cd0cbf) into master (c21be48) will decrease coverage by 0.12%.
The diff coverage is 19.06%.

@@            Coverage Diff             @@
##           master     #320      +/-   ##
==========================================
- Coverage   27.06%   26.93%   -0.13%     
==========================================
  Files          47       47              
  Lines        7265     7543     +278     
==========================================
+ Hits         1966     2032      +66     
- Misses       5299     5511     +212     
Flag Coverage Δ
unittests 26.93% <19.06%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
analysis/topEFT/get_datacard_yields.py 0.00% <0.00%> (ø)
analysis/topEFT/make_cr_and_sr_plots.py 0.00% <0.00%> (ø)
topcoffea/modules/YieldTools.py 46.24% <34.81%> (-6.78%) ⬇️
analysis/topEFT/get_yield_json.py 91.66% <100.00%> (ø)
topcoffea/modules/utils.py 24.47% <0.00%> (+0.69%) ⬆️
topcoffea/modules/WCFit.py 13.96% <0.00%> (+1.50%) ⬆️
topcoffea/modules/WCPoint.py 46.87% <0.00%> (+25.00%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kmohrman
Copy link
Contributor Author

kmohrman commented Sep 21, 2022

Note that the updates to the topeft.py processor and selection.py are probably not relevant enough to necessitate merging into the master (the updates were mostly for the additional variables and histograms we looked into during the unblinding cross checks), so I have restored these files to the master branch version.

The modifications have been moved to the additional-histos branch, documented on this closed PR 325

@kmohrman kmohrman changed the title WIP: Updates to tools for unblinding checks Updates to tools for unblinding checks Sep 21, 2022
@kmohrman
Copy link
Contributor Author

I think this PR should now be ready to be merged (assuming CI passes). The updates are mainly to the tools we use to study the output pkl files (the plotter script, and the yield getting scripts), so this PR should have no impact whatsoever on the actual content of the output pkl file.

@kmohrman kmohrman requested a review from bryates September 21, 2022 20:13
Copy link
Contributor

@bryates bryates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding all of this. I don't have any comments, other than some commented code that we could probably remove.

@kmohrman kmohrman merged commit 447dfde into master Sep 21, 2022
@kmohrman kmohrman deleted the sr-data-mc-plots branch September 21, 2022 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants