-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to tools for unblinding checks #320
Conversation
Codecov Report
@@ Coverage Diff @@
## master #320 +/- ##
==========================================
- Coverage 27.06% 26.93% -0.13%
==========================================
Files 47 47
Lines 7265 7543 +278
==========================================
+ Hits 1966 2032 +66
- Misses 5299 5511 +212
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Note that the updates to the The modifications have been moved to the |
I think this PR should now be ready to be merged (assuming CI passes). The updates are mainly to the tools we use to study the output pkl files (the plotter script, and the yield getting scripts), so this PR should have no impact whatsoever on the actual content of the output pkl file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding all of this. I don't have any comments, other than some commented code that we could probably remove.
This PR includes most of the minor updates I've been making since we began unblinding, but none of these changes should actually impact the results (i.e. they do not change our analysis pkl files, or the datacards etc., they only provide updates to our tools for the studies we've been doing since unblinding).
I don't think this PR is ready to be merged, as most of the changes are quite messy. However, I wanted to make the PR now, just so I can get an idea of what changes are included here, and clean things up when I get a chance, so that we can eventually get this into the master (since it's getting to the point where I'd like to have at least some of these updates in the master branch).