-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix xsec conflicts #58
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @anpicci. This only covers wrong xsecs, not any of the duplicates that were spotted recently?
The conflicts should be solved, but some need additional discussion.
|
@bryates it fixes the duplicates as well, apart from what was reported above (and what I could have missed) |
Ok thanks, I missed that other message the first time. |
Thanks very much @anpicci for these updates! To respond to some of your comments above:
If both samples are available, and if they have slightly different cross sections, I guess it would be ok to include both? But I think the naming and/or comments should make it explicitly clear which is which. And I think if you could add a comment with a link wherever it says the powheg one is recommended that would be great.
Yes, for these I believe we use the K factors as written in the comment (the k factors are already applied to these numbers, I think), but @MatthewDittrich can confirm. |
Actually, I believe there is no k-factor applied here. The value with the k-factor applied is: Also for the GluGlu samples, there will be an added K in the name when the value has a K-factor applied. Such as:
We are not. I think these samples are not used in ewkcoffea as of now. |
@anpicci I am wondering if the "to"/"To" issue has been addressed? If so, what was decided? |
What's the official CMS naming scheme? Maybe we should just adhere to that. |
"to" seems to be more adherent to the official sample names (although there are samples with "To" as well, so it is not 100% consistent within CMS it seems) |
Ok, maybe we should just match whatever the process name is. What do you think @kmohrman @anpicci? |
@bryates I agree sticking with the CMS naming convention is better. However, it looks like it has changed between Run2 and Run3, so we might want to take whatever the CMS central sample name is, and adopt it here, without assuming it is always "to" or always "To". |
Yes, the convention has changed. I was hoping we could stick to the newer one (used for Run 3), but I agree we can just stick to whatever the sample name is. |
@anpicci I was just wondering about the status of this PR? |
This PR is intended to fix the conflicts between xsecs reported in the corresponding yaml.
FYI @bryates @kmohrman