Dask hists

[btovar]

HistEFT to dask

[bryates]

Thanks @btovar! I see a few lint errors
https://github.com/TopEFT/topcoffea/actions/runs/9601776949/job/26481071313?pr=33#step:4:32
Let's see how the main CI runs.

[bryates]

FYI I triggered a CI check in TopEFT using this branch. If that passes, then I'll be happy with merging this PR.

[bryates]

@btovar looks like there's a sqrt error
https://github.com/TopEFT/topeft/actions/runs/9602026457/job/26481917295#step:11:42
Not sure how helpful this will be for debugging, since it's in a function you didn't touch, but it's likely due to a call to eval().

[btovar]

There something weird with the tests, though. test_HistEFT_add should be failing...

[Andrew42]

@btovar the CI/CD test that's being done looks to be test_HistEFT_add, but should that instead be test_histEFT_add?

[bryates]

@btovar the CI/CD test that's being done looks to be test_HistEFT_add, but should that instead be test_histEFT_add?

Good catch! I just pushed that. Looks like the unit test is still for HistEFT.

[kmohrman]

Looks like the CI is still failing. Seems to be a ModuleNotFoundError for dask.

[bryates]

Thanks @btovar, I think this looks good.

[bryates]

Is the comma needed? I guess it doesn't hurt anything.

[bryates]

@btovar do we need to add dask to the environment yml?
https://github.com/TopEFT/topcoffea/actions/runs/9617418237/job/26529122963?pr=33#step:11:22

[btovar]

Ah yes, the old coffea does not add them.

[bryates]

Ah yes, the old coffea does not add them.

Ok, now it's an issue with the label keyword

E   TypeError: __init__() got an unexpected keyword argument 'label'

[bryates]

@btovar looks like the current CI failure might just be a precision issue
https://github.com/TopEFT/topcoffea/actions/runs/9649881600/job/26614283607?pr=33#step:11:32
It's just slightly above 1e-10

[bryates]

Thanks @btovar! Looks like the CI here is passing now. I've restarted the CI on TopEFT to make sure it works there as well.

[btovar]

Nice! I need to update topEFT, though, and probably propagate changes to this pr.

[bryates]

Nice! I need to update topEFT, though, and probably propagate changes to this pr.

Nice! I need to update topEFT, though, and probably propagate changes to this pr.

Nice! I need to update topEFT, though, and probably propagate changes to this pr.

Ok thanks. It's complaining about wc_names
https://github.com/TopEFT/topeft/actions/runs/9650133511/job/26615134823#step:12:143
Is that related to what you need to change?

[btovar]

I think so. For the new hists the axes need to be separated into lists of category or dense so that we know which axes are available at dask graph construction time.

[kmohrman]

Just for topcoffea bookkeeping purposes (since we are getting to have quite a few PRs open, so I'm just trying to make sure we know which are active), I'm wondering if someone could please comment on the status/plans for this PR?

[bryates]

Just for topcoffea bookkeeping purposes (since we are getting to have quite a few PRs open, so I'm just trying to make sure we know which are active), I'm wondering if someone could please comment on the status/plans for this PR?

This has definitely fallen to the back of the queue. There's still a lot of debugging to do for this PR. Right now the task graph is having trouble with some of the calls inside histEFT, which require knowing the sizes of the coefficient arrays at runtime.

[kmohrman]

Just for topcoffea bookkeeping purposes, I'm wondering if someone could please comment on the status/plans for this PR?

[bryates]

Just for topcoffea bookkeeping purposes, I'm wondering if someone could please comment on the status/plans for this PR?

This branch is currently stalled. We'd like to get back to it as some point, maybe after the new year.