This repository has been archived by the owner on May 5, 2023. It is now read-only.
Add support for env vars by default (#11) #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TooTallNate
reviewed
Jan 15, 2018
index.js
Outdated
| function httpOrHttps(opts, secureEndpoint) { | ||
| if (secureEndpoint) { | ||
| // HTTPS | ||
| return new HttpsAgent(); |
There was a problem hiding this comment.
I'm thinking we should use http.globalAgent and https.globalAgent instead 🤔
jackjocross
force-pushed
the
feature/use-env-vars
branch
from
be5d73e to
0b41851
Compare
|
@TooTallNate let me know if there are any other changes I should make! |
|
Really good stuff @crosscompile! Thank you. |
Closed
|
I'd love to use this, but it doesn't look like it's actually been released. Any chance you could publish this sometime soon @TooTallNate? |
|
Thank you for adding this @crosscompile! <3 Going to be super easy to support http proxies in https://github.com/cdr/code-server now! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you declare a
new ProxyAgent()without passing anyopts, proxy-from-env will be used to determine whether to use a proxy or the defaulthttp.Agent.In order to support the
NO_PROXYenvironment variable, I had to add some logic in theconnectfunction to resolve the proxy for each request if initialoptsweren't passed in.I am not very familiar with
http.Agent, but tried usingagent.addRequestafter reading through the source code. Let me know if you think I should take a different approach to anything in this PR.