Use QtPy abstraction layer #144
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In test_browse_button_calls_browse_for_dir only the browse_for_dir() method needs mocking
|
potentially this will close |
paskino
reviewed
Apr 25, 2024
| @@ -5,5 +5,5 @@ channels: | |||
| dependencies: | |||
| - python | |||
| - pip | |||
| - pyside2 | |||
There was a problem hiding this comment.
The user will need to remember to install a Qt binding package. Do we want that?
4 tasks
|
Thanks @samtygier-stfc closing this as superseded by #146 |
DanicaSTFC
added a commit
that referenced
this pull request
Jan 6, 2025
…146) - Use `qtpy` as virtual Qt binding package. GHA unit tests are run with PySide2 and PyQt5 (#146) - Add `pyqt_env.yml` and `pyside_env.yml` environment files (#146) - Update `CONTRIBUTING.md`, `README.md` and add documentation file (#146) Co-authored-by: Sam Tygier <[email protected]> Danica Sugic <[email protected]>
|
@samtygier-stfc we merged your PR in #146 Thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2
This switches to importing Qt classes via the qtpy abstraction layer. The library will then use which ever Qt binding you have in your environment. If you have multiple, its possible to select one using an environment variable (see https://github.com/spyder-ide/qtpy).
A small change to some mocking in a test was needed.
This passes all the tests, but has not been tested for an application that uses the library.
An application that uses eqt, will now need to add a dependency on the Qt binding that it wants to use.