-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore bots signoff check #59
Ignore bots signoff check #59
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dolby360
We have 3 typos failing test, and the CI workflows:
here:
.withArgs(fakeUnknownEmail, sinon.match.func)
change fakeUnknownEmail
to fakeBotEmail
.
here:
listCommitsStub.resolves({data: [commitSignedByUnknown]});
change commitSignedByUnknown
to commitUnsignedBot
.
the commit message type is feat!
, amend it to feat
.
in case that a branch contains bot commits then these commits will not be checked. this code assume that the email address of all bots contains [bot]. Signed-off-by: dolby360 <[email protected]>
ca844ee
to
f780005
Compare
@dolby360 I just want to take the opportunity of this PR and fix the CI issue, Can you please verify the |
Already on. Please take your time there's no rush. |
Weird... I try pushing yesterday, and I got a permissions error, I figured it's the maintainers' thing, but I didn't look anymore into it. I am looking into it now. EDIT: EDIT 2: |
c201c70
to
f780005
Compare
in case a branch contains bot commits then these commits will not be checked.
this code assumes that the email address of all bots contains [bot].
Signed-off-by: dolby360 [email protected]
Pull Request
Description
Related issue (if any): fixes #47
Checklist
Additional information