feat: Check that enum from_int functions are correct.
#212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iphydf
force-pushed
the
enum-from-int
branch
3 times, most recently
from
77fc957 to
bacecee
Compare
iphydf
added a commit
to iphydf/c-toxcore
that referenced
this pull request
Dec 18, 2023
These functions are a bit clearer and don't need to change if enum values change. See TokTok/hs-tokstyle#212 for the relevant linter implementation.
iphydf
added a commit
to iphydf/c-toxcore
that referenced
this pull request
Dec 18, 2023
These functions are a bit clearer and don't need to change if enum values change. See TokTok/hs-tokstyle#212 for the relevant linter implementation.
JFreegman
approved these changes
Dec 18, 2023
There was a problem hiding this comment.
Reviewed 20 of 20 files at r1, all commit messages.
Reviewable status:complete! 1 of 1 approvals obtained
iphydf
force-pushed
the
enum-from-int
branch
from
bacecee to
f66f6c1
Compare
This is the first "semantic formatter" style linter. It's pretty simple
and just checks that all enumerators are present and there is a sane
default in the `${enum}_from_int` functions. There is no compiler
warning we can use for this, because the int can contain anything.
Currently, if there is an enumerator ending in `_INVALID`, then that is
the default, otherwise the first enumerator is the default for invalid
int values.
iphydf
added a commit
to iphydf/c-toxcore
that referenced
this pull request
Dec 18, 2023
These functions are a bit clearer and don't need to change if enum values change. See TokTok/hs-tokstyle#212 for the relevant linter implementation.
iphydf
force-pushed
the
enum-from-int
branch
from
f66f6c1 to
c36fa4e
Compare
iphydf
added a commit
to iphydf/c-toxcore
that referenced
this pull request
Dec 19, 2023
These functions are a bit clearer and don't need to change if enum values change. See TokTok/hs-tokstyle#212 for the relevant linter implementation.
iphydf
added a commit
to iphydf/c-toxcore
that referenced
this pull request
Dec 19, 2023
These functions are a bit clearer and don't need to change if enum values change. See TokTok/hs-tokstyle#212 for the relevant linter implementation.
iphydf
added a commit
to iphydf/c-toxcore
that referenced
this pull request
Dec 19, 2023
These functions are a bit clearer and don't need to change if enum values change. See TokTok/hs-tokstyle#212 for the relevant linter implementation.
iphydf
added a commit
to iphydf/c-toxcore
that referenced
this pull request
Dec 19, 2023
These functions are a bit clearer and don't need to change if enum values change. See TokTok/hs-tokstyle#212 for the relevant linter implementation.
iphydf
added a commit
to iphydf/c-toxcore
that referenced
this pull request
Dec 19, 2023
These functions are a bit clearer and don't need to change if enum values change. See TokTok/hs-tokstyle#212 for the relevant linter implementation.
iphydf
added a commit
to iphydf/c-toxcore
that referenced
this pull request
Dec 19, 2023
These functions are a bit clearer and don't need to change if enum values change. See TokTok/hs-tokstyle#212 for the relevant linter implementation.
iphydf
added a commit
to iphydf/c-toxcore
that referenced
this pull request
Dec 19, 2023
These functions are a bit clearer and don't need to change if enum values change. See TokTok/hs-tokstyle#212 for the relevant linter implementation.
iphydf
added a commit
to iphydf/c-toxcore
that referenced
this pull request
Dec 19, 2023
These functions are a bit clearer and don't need to change if enum values change. See TokTok/hs-tokstyle#212 for the relevant linter implementation.
iphydf
added a commit
to iphydf/c-toxcore
that referenced
this pull request
Dec 19, 2023
These functions are a bit clearer and don't need to change if enum values change. See TokTok/hs-tokstyle#212 for the relevant linter implementation.
iphydf
added a commit
to iphydf/c-toxcore
that referenced
this pull request
Dec 19, 2023
These functions are a bit clearer and don't need to change if enum values change. See TokTok/hs-tokstyle#212 for the relevant linter implementation.
iphydf
added a commit
to iphydf/c-toxcore
that referenced
this pull request
Dec 19, 2023
These functions are a bit clearer and don't need to change if enum values change. See TokTok/hs-tokstyle#212 for the relevant linter implementation.
freylax
pushed a commit
to nodecum/c-toxcore
that referenced
this pull request
Jan 13, 2024
These functions are a bit clearer and don't need to change if enum values change. See TokTok/hs-tokstyle#212 for the relevant linter implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first "semantic formatter" style linter. It's pretty simple and just checks that all enumerators are present and there is a sane default in the
${enum}_from_intfunctions. There is no compiler warning we can use for this, because the int can contain anything. Currently, if there is an enumerator ending in_INVALID, then that is the default, otherwise the first enumerator is the default for invalid int values.This change is