Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add shared_key_is_empty(...) to pure functions #196

Merged
merged 1 commit into from
Aug 7, 2022
Merged

fix: add shared_key_is_empty(...) to pure functions #196

merged 1 commit into from
Aug 7, 2022

Conversation

sudden6
Copy link
Contributor

@sudden6 sudden6 commented Jun 5, 2022 •
edited
Loading

This prevents a warning because it's used in an assert in #2317

This change is Reviewable

@auto-add-label auto-add-label bot added the bug Bug fix for the user, not a fix to a build script label Jun 5, 2022
robinlinden
robinlinden requested changes Jun 6, 2022
View reviewed changes
Copy link
Member

@robinlinden robinlinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is indented using a tab instead of the spaces it should be using?

robinlinden
robinlinden approved these changes Jun 6, 2022
View reviewed changes
Copy link
Member

@robinlinden robinlinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, nvm, CI already blocks on that.

@sudden6 sudden6 force-pushed the add_pure_function branch from 2adcdcf to b7ffe5f Compare August 7, 2022 17:45
@sudden6 sudden6 added this to the v0.0.9 milestone Aug 7, 2022
@sudden6
fix: add shared_key_is_empty(...) to pure functions
f0abdb9 
This prevents a warning because it's used in an assert.
@sudden6 sudden6 force-pushed the add_pure_function branch from b7ffe5f to f0abdb9 Compare August 7, 2022 17:57
@sudden6 sudden6 merged commit f0abdb9 into TokTok:master Aug 7, 2022
@sudden6
Copy link
Contributor Author

sudden6 commented Aug 7, 2022

@iphydf @robinlinden this didn't have the desired effect, TokTok/c-toxcore#2317 is still failing, does the change need to propagate somewhere?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robinlinden robinlinden robinlinden approved these changes

@iphydf iphydf iphydf approved these changes

Assignees

@sudden6 sudden6

Labels
bug Bug fix for the user, not a fix to a build script
Milestone
v0.0.9
Development

Successfully merging this pull request may close these issues.
3 participants
@sudden6 @robinlinden @iphydf