Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(toxav): pass video bit rate as kbit #2782

Merged
merged 1 commit into from
Nov 9, 2024

Conversation

Green-Sky
Copy link
Member

@Green-Sky Green-Sky commented Nov 8, 2024

Previously we unintentionally made it Mbit.


This change is Reviewable

@Green-Sky
Copy link
Member Author

Green-Sky commented Nov 8, 2024

@Green-Sky Green-Sky added this to the v0.2.20 milestone Nov 8, 2024
@Green-Sky Green-Sky added bug Bug fix for the user, not a fix to a build script toxav Audio/video labels Nov 8, 2024
@Green-Sky Green-Sky requested a review from a team November 8, 2024 16:01
@Green-Sky Green-Sky force-pushed the toxav_fix_video_bitrate branch from 724103b to fa723e3 Compare November 8, 2024 16:18
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.96%. Comparing base (5f97890) to head (fa723e3).
Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2782      +/-   ##
==========================================
- Coverage   73.04%   72.96%   -0.08%     
==========================================
  Files         149      149              
  Lines       30478    30566      +88     
==========================================
+ Hits        22263    22303      +40     
- Misses       8215     8263      +48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Previously we unintentionally made it Mbit.
@Green-Sky Green-Sky force-pushed the toxav_fix_video_bitrate branch from fa723e3 to 55752a2 Compare November 9, 2024 00:12
@toktok-releaser toktok-releaser merged commit 55752a2 into TokTok:master Nov 9, 2024
62 checks passed
@Green-Sky Green-Sky deleted the toxav_fix_video_bitrate branch November 9, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug fix for the user, not a fix to a build script toxav Audio/video
Development

Successfully merging this pull request may close these issues.

3 participants