-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup: event length naming inconsistencies #2732
cleanup: event length naming inconsistencies #2732
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2732 +/- ##
=======================================
Coverage 72.99% 72.99%
=======================================
Files 149 149
Lines 30516 30516
=======================================
Hits 22276 22276
Misses 8240 8240 ☔ View full report in Codecov by Sentry. |
1788d56
to
c66099e
Compare
c66099e
to
6c340c8
Compare
6c340c8
to
18b870f
Compare
18b870f
to
93ad4ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: complete! 1 change requests, 1 of 1 approvals obtained (waiting on @Green-Sky)
other/event_tooling/generate_event_c.cpp
line 783 at r1 (raw file):
they are :)
kinda makes no sense if you didn't see the original comment
toxcore/events/group_message.c
line 257 at r1 (raw file):
void tox_events_handle_group_message( Tox *tox, uint32_t group_number, uint32_t peer_id, Tox_Message_Type type, const uint8_t *message, size_t message_length, uint32_t message_id,
message_type?
toxcore/events/group_private_message.c
line 257 at r1 (raw file):
void tox_events_handle_group_private_message( Tox *tox, uint32_t group_number, uint32_t peer_id, Tox_Message_Type type, const uint8_t *message, size_t message_length, uint32_t message_id,
message_type?
93ad4ec
to
8163932
Compare
8163932
to
2048c81
Compare
2048c81
to
87ab6d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: 1 change requests, 0 of 1 approvals obtained (waiting on @Green-Sky and @nurupo)
9151bcd
to
6c1fe91
Compare
6c1fe91
to
0199c0f
Compare
Also applies to types.
This change is